WEB3-293: feat: Add risc0-ethereum-trie
#391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
risc0-ethereum-trierisc0-ethereum-trie
nategraf
reviewed
Jan 18, 2025
There was a problem hiding this comment.
I've started to look through this. No substantial comments so far. Did you work on this with @hashcashier? In either case, it'd be great to have Rami's review. I'm definitely lacking some understanding of the Ethereum Trie that would be required to really find issues here.
crates/trie/rustfmt.toml
Outdated
Comment on lines
5
to
12
| # Nightly | ||
| max_width = 100 | ||
| comment_width = 100 | ||
| imports_granularity = "Crate" | ||
| wrap_comments = true | ||
| format_code_in_doc_comments = true | ||
| doc_comment_code_block_width = 100 | ||
| format_macro_matchers = true |
There was a problem hiding this comment.
We've generally turned off nightly features for rust fmt in other crates.
There was a problem hiding this comment.
That is a shame, I think those settings improve readability.
I removed the nightly options, but kept the non-nightly ones because I think they add a lot to readability.
This reverts commit 81bc5ab.
Co-authored-by: Victor Snyder-Graf <[email protected]>
nategraf
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new
risc0-ethereum-triecrate consolidating all functionality related to sparse Merkle-Patricia Tries (MPT).Merge #390 first