ci(docker): unify fast-docker-build-arm into github action
#23402
Conversation
| steps: | ||
| - label: "docker-build-push: aarch64" | ||
| if: build.env("SKIP_TARGET_AARCH64") != "true" | ||
| command: "CARGO_PROFILE=patch-production ci/scripts/docker.sh" |
There was a problem hiding this comment.
CARGO_PROFILE=patch-production is not retained in this PR. Shall we:
- expose it as one more additional checkbox / choice
- assume it when
skip_target_amd64is checked - drop it
There was a problem hiding this comment.
assume it when skip_target_amd64 is checked
This. It should speed up the production build, since it skips lto.
There was a problem hiding this comment.
Renamed the option from skip_target_amd64 to fast_build, and preserved the CARGO_PROFILE.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
| commit: HEAD | ||
| message: ':github: Triggering Docker build with image tag: ${{ env.IMAGE_TAG }}' | ||
| build_env_vars: '{ "IMAGE_TAG": "${{ env.IMAGE_TAG }}", "PUSH_DOCKERHUB": "${{ env.PUSH_DOCKERHUB }}" }' | ||
| build_env_vars: '{ "IMAGE_TAG": "${{ env.IMAGE_TAG }}", "PUSH_DOCKERHUB": "${{ env.PUSH_DOCKERHUB }}" }' |
There was a problem hiding this comment.
Updating this line to pass SKIP_TARGET_AMD64 and CARGO_PROFILE to buildkite in a followup PR. I was only testing the shell script above by disabling the actual buildkite part 🤦
After that I will cherry-pick this together with it to release branches.
|
✅ Cherry-pick PRs (or issues if encountered conflicts) have been created successfully to all target branches. |
…#23562) Co-authored-by: xiangjinwu <[email protected]>
…#23562) Co-authored-by: xiangjinwu <[email protected]>
…#23562) Co-authored-by: xiangjinwu <[email protected]>
…#23566) Co-authored-by: risingwave-ci <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Prior context: #18124
Checklist
Documentation
Release note