Skip to content

fix: use counter instead of gauge for error metrics (#23522) #23550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-2.6
Choose a base branch
from
Open

fix: use counter instead of gauge for error metrics (#23522) #23550

wants to merge 2 commits into from
+50 −118

Conversation

@hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Oct 23, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #23548

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@hzxa21 hzxa21 requested review from cyliu0 and wenym1 October 23, 2025 03:04
@hzxa21 hzxa21 requested a review from a team as a code owner October 23, 2025 03:04
@github-actions github-actions bot added ci/main-cron/run-all type/fix Type: Bug fix. Only for pull requests. labels Oct 23, 2025
@graphite-app graphite-app bot requested a review from lmatz October 25, 2025 17:26
@graphite-app
Copy link

graphite-app bot commented Oct 25, 2025

Graphite Automations

"release branch request review" took an action on this PR • (10/25/25)

1 reviewer was added to this PR based on xxchan's automation.

@hzxa21 hzxa21 enabled auto-merge October 30, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyliu0 cyliu0 Awaiting requested review from cyliu0

@wenym1 wenym1 Awaiting requested review from wenym1

@lmatz lmatz Awaiting requested review from lmatz

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

ci/main-cron/run-all type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hzxa21