Skip to content

Conversation

@Standing-Man
Copy link
Contributor

@Standing-Man Standing-Man commented Oct 23, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

support gamma and lgamma function

@Standing-Man Standing-Man requested a review from a team as a code owner October 23, 2025 09:02
@Standing-Man Standing-Man requested review from hzxa21 and removed request for a team October 23, 2025 09:02
@Standing-Man
Copy link
Contributor Author

Hi @hzxa21, I’m a bit unsure whether the gamma function should be wrapped in the F64.

fn to_radians(self) -> Self {

related issue: rust-lang/rust#99842

@Standing-Man Standing-Man force-pushed the gamma-func branch 3 times, most recently from 4f6ddd0 to 543e4af Compare October 24, 2025 01:37
@hzxa21
Copy link
Collaborator

hzxa21 commented Oct 27, 2025

Hi @hzxa21, I’m a bit unsure whether the gamma function should be wrapped in the F64.

fn to_radians(self) -> Self {

related issue: rust-lang/rust#99842

cc the original author of ordered_float to check @BugenZhao

@BugenZhao BugenZhao self-requested a review October 27, 2025 13:03
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. Thanks for contribution!

@BugenZhao BugenZhao requested a review from xiangjinwu October 29, 2025 02:28
@Standing-Man
Copy link
Contributor Author

Standing-Man commented Oct 31, 2025

Hi @xiangjinwu, PTAL when you have time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants