Skip to content

Conversation

@tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

per requested

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

add pulsar.read_compacted to control the pulsar consumer read from the compacted topic or not. Not allowed to change on the fly.

@github-actions github-actions bot added the type/feature Type: New feature. label Oct 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the pulsar.read_compacted option in Pulsar consumer properties, allowing users to control whether the consumer reads from compacted topics. The implementation introduces a new PulsarConsumerOptions struct to encapsulate consumer-specific settings and integrates this option into the existing Pulsar connector configuration.

Key Changes:

  • Added pulsar.read_compacted boolean field to Pulsar source properties configuration
  • Created new PulsarConsumerOptions struct to organize consumer-specific options
  • Integrated the read_compacted option into the Pulsar consumer initialization logic

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/connector/with_options_source.yaml Adds the pulsar.read_compacted field definition to PulsarProperties schema
src/connector/src/source/pulsar/mod.rs Introduces PulsarConsumerOptions struct and integrates it into PulsarProperties
src/connector/src/source/pulsar/source/reader.rs Applies the read_compacted setting to Pulsar consumer options during initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants