Skip to content

Conversation

@kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Oct 28, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After this PR, you can use:

./risedev sr <sql script file>

To reduce your failing SQL query.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the type/feature Type: New feature. label Oct 28, 2025
@kwannoel kwannoel requested a review from Copilot October 29, 2025 10:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Makefile.toml tasks for building and running the sqlsmith-reducer tool, which reduces failing SQL queries to minimal reproducible cases while preserving errors. It also adds the .sqlsmith/ directory to .gitignore to exclude generated reducer output.

  • Adds three new tasks: build-sqlsmith-reducer, sql-reduce-short (alias sr), and sql-reduce-full for building and running the SQL query reducer
  • Adds .sqlsmith/ directory to .gitignore for temporary reducer output files

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.

File Description
Makefile.toml Adds task definitions for building sqlsmith-reducer and running SQL reduction operations
.gitignore Excludes the .sqlsmith/ directory used for temporary reducer output

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kwannoel
Copy link
Contributor Author

@copilot please address the unresolved review comments in this PR.

Copy link
Contributor

Copilot AI commented Oct 29, 2025

@kwannoel I've opened a new pull request, #23606, to work on those changes. Once the pull request is ready, I'll request review from you.

@kwannoel kwannoel requested review from BugenZhao and Copilot October 30, 2025 12:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

@kwannoel kwannoel force-pushed the kwannoel/sqlsmith-risedev branch from 3e65dee to c8cf57b Compare October 31, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants