Skip to content

refactor(storage): replace raw u32 table id with strong typed table id #23621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(storage): replace raw u32 table id with strong typed table id #23621

wants to merge 2 commits into from
+799 −637

Conversation

@wenym1
Copy link
Contributor

@wenym1 wenym1 commented Oct 31, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@wenym1 wenym1 marked this pull request as ready for review October 31, 2025 07:59
@wenym1 Graphite App
Copy link
Contributor Author

wenym1 commented Oct 31, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wenym1 wenym1 changed the title refactor: replace raw u32 table id with strong typed table id refactor(storage): replace raw u32 table id with strong typed table id Oct 31, 2025
@wenym1 wenym1 requested review from Li0k, hzxa21 and zwang28 October 31, 2025 08:04
@wenym1 wenym1 force-pushed the yiming/strong-typed-table-id branch from 4792f48 to efba20f Compare October 31, 2025 08:06
@wenym1 wenym1 added this pull request to the merge queue Oct 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Li0k Li0k Li0k approved these changes

@hzxa21 hzxa21 Awaiting requested review from hzxa21

@zwang28 zwang28 Awaiting requested review from zwang28

Assignees

No one assigned

Labels

ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends type/refactor Type: Refactoring.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wenym1 @Li0k