Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reminder and schedule feature #102

Merged
merged 5 commits into from
Oct 21, 2020
Merged

Conversation

vnksnkr
Copy link
Contributor

@vnksnkr vnksnkr commented Oct 18, 2020

#16
I've added a reminder feature that writes schedules into a .dat file and reminds the events on a particular day

@ritwik12
Copy link
Owner

@vnksnkr Can you also make the README.md changes for this so that one can know how to use this feature.

Copy link
Owner

@ritwik12 ritwik12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vnksnkr That's really nice work, Appreciate it. A few changes needs to be done. Please go through those. Also, can you please add an Image of your working feature in a cool way just like we have for all others in the Readme.md in that Reminder section of yours? That would be really nice.

@ritwik12
Copy link
Owner

@vnksnkr One important thing that I want to tell you which I noticed while going through your README and codes. You assumed that these are commands to make virtual assistant perform some tasks. No it isn't, we use AI here to make virtual assistant understand what the user wants. Those words are the keywords in the knowledge base only. Not the exact commands. You can know more from README.md

@ritwik12 ritwik12 merged commit 0ab90fc into ritwik12:master Oct 21, 2020
@ritwik12
Copy link
Owner

@vnksnkr Thanks a lot!!

@ritwik12
Copy link
Owner

@all-contributors please add @vnksnkr for code and doc

@allcontributors
Copy link
Contributor

@ritwik12

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected string in JSON at position 871

@ritwik12
Copy link
Owner

@all-contributors please add @vnksnkr for code and doc

@allcontributors
Copy link
Contributor

@ritwik12

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected string in JSON at position 871

@ritwik12
Copy link
Owner

@all-contributors please add @vnksnkr for code and doc

@allcontributors
Copy link
Contributor

@ritwik12

I've put up a pull request to add @vnksnkr! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants