Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight matching braces in decompiler view #3285

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

skoriop
Copy link
Contributor

@skoriop skoriop commented Jan 24, 2024

Your checklist for this pull request

Detailed description

When you click on a { or } in the decompiler view, only the matching brace is highlighted (instead of highlighting all braces of the same type.

Test plan (required)

Open any binary that has braces in its decompiled view.

2024-01-24.21-16-53.mp4

Closing issues

closes #3255

@karliss karliss self-requested a review January 25, 2024 09:21
Copy link
Member

@karliss karliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a quick and dirty solution I would say this good enough, not like the variable highlighting was much better. But in longer term this should be handled using rz_annotated_code instead of regex based guesswork, decompiler should already have all the required information and much more accurate it just needs to be used.

@karliss karliss merged commit e3087e7 into rizinorg:dev Jan 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight matching braces in decompiler view
2 participants