Merge Vector instruction COT project#22
Draft
pollo-fritto wants to merge 20 commits intorl-language:masterfrom
Draft
Merge Vector instruction COT project#22pollo-fritto wants to merge 20 commits intorl-language:masterfrom
pollo-fritto wants to merge 20 commits intorl-language:masterfrom
Conversation
drblallo
reviewed
Aug 27, 2025
Contributor
There was a problem hiding this comment.
i guess this is the file with the optimized dictionary implementation? if it is better than the previous one it should just entirelly replace that
| passManager.addPass( | ||
| MPM.addPass( | ||
| createModuleToFunctionPassAdaptor(std::move(functionPassManager))); | ||
| if (emitSanitizerInstrumentation and not targetIsWindows) |
Contributor
There was a problem hiding this comment.
there is something going on here that happen probably due to the rebasing. it seem that ode that was there before has been accidentally removed.
Author
There was a problem hiding this comment.
These instructions were repeated in both branches' end, I just moved them down
| }; | ||
| }; | ||
|
|
||
| struct mlir::rlc::TargetInfoImpl |
Contributor
There was a problem hiding this comment.
i know that this is probably due to the rebase, but does this piece of code really need to be moved away from its original location?
Author
There was a problem hiding this comment.
I need it to be before runOptimizer() because one of its arguments has this structure type
…th an example on both rl and c language, with their IR outputs and yaml pass remarks
…ne print from rlc to llvm
…e name and line number
… and specification of a Target Machine for the Pass Manager Builder. This makes rlc -O2 vectorization equals to opt -O2 for rlc/tool/rlc/test/examples/vectorization/dict.rl
No more get target machine procedure on runOptimizer() but passed as a func arg
…nt bench, add base case to grow()
…ench script and dict test Soa_dictionary is a structure of array version of the dictionary implementation, in this way it possible to achieve vectorization. Now contains() get vectorized
The new merge_bench separate every different measurement in different files. In this way we can compare the same benchmark from different commits
Fix _grow() bug in size 0 case, contains() improved with early exit if first element of stride empty
contains() and _insert() were bugged, the accumulator of condition was in or instead of and, _insert() had a totally wrong implementation of distance check. get() and remove() vectorized, remove() to be finished. To check if the 4 above get vectorized.
…() vectorized Update merge_bench.sh description
Soa_dictionary seems to work fine if using _index_binary_search(), but it does not vectorize get() and remove(). Add print_dict() for testing and many print for debugging purposes
Add different approaches to index_of, none works
pollo-fritto
force-pushed
the
vect-instr-closing-project
branch
from
11035ba to
76b28e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following is a brief per file description of the changes:
BackEnd.cpp: the changes enable the SLP vectorizer and to run optimization passes leveraging the target machine capabilities. These changes match the vectorized code produced by
optConversion.cpp: I still need to figure out if these changes are beneficial, I will benchmark them. If they are detrimental, I will remove them from the merge
DictIntBenchBenchmark.cpp: just an increase to the dictionary benchmark range
merge_benchs.sh: this script is meant to group benchmarks from different files in order to have a single plot of the same benchmark in different runs.
It is a work in progress, ignore it for now.SoA_dictionary.rl: This is a structure of array version of the dictionary container. It allows vectorization of get(), remove() and contains(). Still to be benchmarked, I expect a performance gain for large dictionaries
dictionary.rl: edit a wrong function comment