Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Simisani & Meenakshi profile #370

Merged
merged 6 commits into from
Feb 17, 2025
Merged

add Simisani & Meenakshi profile #370

merged 6 commits into from
Feb 17, 2025

Conversation

SoyAndrea
Copy link
Contributor

@SoyAndrea SoyAndrea requested review from a team as code owners January 9, 2025 02:18
@SoyAndrea SoyAndrea requested a review from cosimameyer January 9, 2025 02:18
@SoyAndrea SoyAndrea mentioned this pull request Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

🎉 The preview is built! Check it out 👀

Copy link

Test build failed 😭 Check out the build logs.

Copy link

🎉 The preview is built! Check it out 👀

@SoyAndrea
Copy link
Contributor Author

Hi everyone! I have already updated the rocur teams from twitter and bluesky. it's ready for update, Only one approval is missing :) @rladies/website

@cosimameyer
Copy link
Contributor

@SoyAndrea not entirely sure but it looks like you have to review the code again. I updated it with main. If it looks good for you and the test builds are successful, you can go ahead and merge it :)

Copy link

🎉 The preview is built! Check it out 👀

Copy link

🎉 The preview is built! Check it out 👀

@SoyAndrea
Copy link
Contributor Author

{B3D49A8A-0523-445A-BB0A-1CBF039FF113}

Hi @cosimameyer! The deploy preview looks good with the changes made, but I don't know which option to choose for the merge to the web: update branch or update with rebase?
(I'll leave the image with the options)

@SoyAndrea not entirely sure but it looks like you have to review the code again. I updated it with main. If it looks good for you and the test builds are successful, you can go ahead and merge it :)

@cosimameyer
Copy link
Contributor

I would pick "Update with merge commit“ (just did it; it’s the normal “merging main into your feature branch”). The actions are now being triggered and we can have a look at them once they are done :)

Copy link

🎉 The preview is built! Check it out 👀

@SoyAndrea SoyAndrea merged commit 03fb92a into main Feb 17, 2025
2 checks passed
@SoyAndrea SoyAndrea deleted the add_rocurteam branch February 17, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants