Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease C++ version requirements in order to support RNP packaging #23

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Mar 18, 2023

This chane is required in order to suppor sexp inclusion too rnp as source code as discussed at rnpgp/rnp#2004

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ec6bcc6) 99.70% compared to head (abbe7f4) 99.70%.

❗ Current head abbe7f4 differs from pull request most recent head a805612. Consider uploading reports for the commit a805612 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files           9        9           
  Lines         668      668           
=======================================
  Hits          666      666           
  Misses          2        2           
Impacted Files Coverage Δ
src/sexp-output.cpp 100.00% <ø> (ø)
include/sexp/sexp.h 100.00% <100.00%> (ø)
src/sexp-input.cpp 100.00% <100.00%> (ø)
src/sexp-object.cpp 98.55% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxirmx maxirmx changed the title Ease C++ reqs Support RNP packaging Mar 18, 2023
@maxirmx maxirmx changed the title Support RNP packaging Ease C++ version requirements in order to support RNP packaging Mar 19, 2023
@maxirmx maxirmx requested review from ronaldtse and ni4 March 19, 2023 16:40
@maxirmx maxirmx marked this pull request as ready for review March 19, 2023 16:40
@maxirmx maxirmx merged commit 3b64922 into main Mar 20, 2023
@maxirmx maxirmx deleted the cpp-reqs branch March 22, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ease C++ version requirements
2 participants