Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local type #273

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Fix local type #273

merged 2 commits into from
Jun 27, 2024

Conversation

iurisilvio
Copy link
Contributor

@iurisilvio iurisilvio commented Jun 27, 2024

Description

Fix the local arg type. It should be an optional string, not a bool.

Ref #271

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Mypy like it.

@iurisilvio iurisilvio requested a review from a team June 27, 2024 15:46
@iurisilvio iurisilvio self-assigned this Jun 27, 2024
@iurisilvio iurisilvio marked this pull request as ready for review June 27, 2024 15:46
@iurisilvio iurisilvio merged commit 708108b into main Jun 27, 2024
8 checks passed
@iurisilvio iurisilvio deleted the iuri/mypy-3 branch June 27, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants