Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last mypy issues #275

Merged
merged 9 commits into from
Jul 2, 2024
Merged

Fix last mypy issues #275

merged 9 commits into from
Jul 2, 2024

Conversation

iurisilvio
Copy link
Contributor

@iurisilvio iurisilvio commented Jun 27, 2024

Description

Ignore some mypy errors because it is hard to fix.

  • .predict() method doesn't follow parent class signature
  • matplotlib doesn't have typings in Python 3.8

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Mypy really passing on CI.

@iurisilvio iurisilvio self-assigned this Jun 28, 2024
@iurisilvio iurisilvio marked this pull request as ready for review June 28, 2024 08:52
@iurisilvio iurisilvio requested a review from a team June 28, 2024 08:52
@iurisilvio iurisilvio merged commit 813d56f into main Jul 2, 2024
8 checks passed
@iurisilvio iurisilvio deleted the iuri/mypy-5 branch July 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants