Skip to content

Add warning for mismatched mimetype and filename extension #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

iurisilvio
Copy link
Contributor

@iurisilvio iurisilvio commented Jul 11, 2024

Description

  • Add support for BMP and WEBP images.
  • Add support for AVI video, mimetype was wrong.
  • Add warn for file mimetype does not match filename extension.
  • Replace magic dependency (and libmagic system dependency) with filetype that is pure Python.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

CI pass.

@iurisilvio iurisilvio force-pushed the iuri/warn-wrong-mimetype branch from 1f67c3a to d4e3bc9 Compare July 11, 2024 11:24
@iurisilvio iurisilvio self-assigned this Jul 11, 2024
@iurisilvio iurisilvio requested a review from stellasphere July 11, 2024 11:37
@iurisilvio iurisilvio marked this pull request as ready for review July 11, 2024 11:37
@iurisilvio iurisilvio requested a review from joaomarcoscrs July 12, 2024 10:03
@iurisilvio iurisilvio merged commit 9c361e3 into main Jul 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants