-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test MJCF descriptions with Pinocchio #103
Draft
stephane-caron
wants to merge
12
commits into
main
Choose a base branch
from
fix/test_pinocchio_mjcf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13765701151Details
💛 - Coveralls |
9a77ff2
to
dfba0d6
Compare
As of today, the Pinocchio version on PyPI is 2.7.0 while that on conda-forge is 3.3.0
561a935
to
d482ef4
Compare
I have tested the following MJCF descriptions at my disposal with Pinocchio 3.4.0 (installed from conda-forge). Most of them (25 / 34) load successfully. I have opened upstream issues for those who don't.
|
Merge remaining loader tests to the description test fixture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocker: the
pin
package on PyPI is currently at version 2.7.0, while we will need a version that includes this change to be able to test MJCF descriptions here.