Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MuJoCo MJX Support - Add Robotiq 2f85 V4 model #120

Conversation

peterdavidfagan
Copy link
Contributor

@peterdavidfagan peterdavidfagan commented Feb 5, 2025

This pull request accomplishes the following:

  1. Updates the commit hash for the mujoco_menagerie library to the latest
  2. Adds the robotiq_2f85_v4 model

@stephane-caron
Copy link
Member

Thank you for starting this 👍 There are a couple of small things to wrap this up, like updating _descriptions.py or the changelog. You can check the step-by-step list in CONTRIBUTING.md.

@coveralls
Copy link

coveralls commented Feb 5, 2025

Pull Request Test Coverage Report for Build 13159372593

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.454%

Totals Coverage Status
Change from base Build 12652899350: 0.02%
Covered Lines: 957
Relevant Lines: 982

💛 - Coveralls

@peterdavidfagan
Copy link
Contributor Author

Thank you for starting this 👍 There are a couple of small things to wrap this up, like updating _descriptions.py or the changelog. You can check the step-by-step list in CONTRIBUTING.md.

Ah yes my bad I'll update this now, originally it was a very quick/messy pass on my side as I was making this change on my local version.

@stephane-caron
Copy link
Member

LGTM, thank you for adding this description 👍

@stephane-caron stephane-caron merged commit 859d1ea into robot-descriptions:main Feb 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants