Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import modules from textiles package does not work without Pycharm #25

Closed
David-Estevez opened this issue Nov 30, 2016 · 2 comments
Closed
Assignees
Labels
bug Something isn't working common

Comments

@David-Estevez
Copy link
Contributor

When importing modules from the textiles package (e.g. common, ironing, etc) outside PyCharm an import error is raised.

This might be due to Pycharm including textiles submodules in the Python path, but needs to be fixed so that it can be run also outside PyCharm.

@David-Estevez David-Estevez added bug Something isn't working common labels Nov 30, 2016
@jgvictores
Copy link
Member

jgvictores commented Nov 30, 2016

Not sure if relevant, but looks like @PeterBowman did a really good job at the asibot-main repository (see this, this and this).

@David-Estevez
Copy link
Contributor Author

Fixed in 9884f18

Relative imports are discouraged for clearness, and a proper textiles Python package didn't exist. The most obvious solution was then to add a textiles package to the repo instead of using the whole repo as a package (this wasn't even recognized by PyCharm). The only thing left, as @jgvictores stated, is to integrate CMake and setuptools to have textiles installed in the system (see issue #38).

Note that the changes done to solve this issue will probably break any hardcoded paths present in the code, but those shouldn't exist to start with, so it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working common
Projects
None yet
Development

No branches or pull requests

2 participants