-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coupled_pendulum tutorial and tests #228
Add coupled_pendulum tutorial and tests #228
Conversation
@@ -0,0 +1,38 @@ | |||
# Run coupled pendulum tutorial in Gazebo | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere here we should document that this model has a runtime dependency on icub-main
.
If you do not have time to add a unit test, we can also just add a tutorial. Let's avoid that further enhancement prevent us to get improvements (see https://en.wikipedia.org/wiki/Perfect_is_the_enemy_of_good). |
Hi @traversaro, sorry for the delay. I'm going to add the unit test by the end of the day, at the latest by tomorrow if you're fine |
No problem, take your time, I just was going through the open issues and PRs. |
Hi @traversaro, at the end I added the coupled pendulum within the tests of the controlBoard (both position and position direct) and I also added the test for checking that the tutorial runs without errors. Since the tutorial depends on icub-main, I protected it with an option that is ON if icub-main is found, OFF otherwise. Please, let me know if it is the intended behavior, thanks! |
There is something I do not understand. The Can you also modify the PR title to mention "Add coupled_pendulum tutorial and tests"? |
option(ENABLE_COUPLED_PENDULUM_TEST "Enable coupled pendulum tests that require ICUB" ON) | ||
else() | ||
set(ENABLE_COUPLED_PENDULUM_TEST OFF) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this logic can be useful for all tests, so I think we can move it upper in the tests CMakeList.txt (see the comment there).
For what regards testing:
If you need any in person clarification feel free to ask me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks @martinaxgloria ! I have nothing to add to the @traversaro suggestions
e7b9cf0
to
b6bb9a7
Compare
4a21ec5
to
d5059d4
Compare
The CI is still failing due to:
This is maybe because the
but pixi install failed locally with this error:
cc @traversaro |
Good point! We still need to release icub-main with coupling support. |
I don't know when the new tag will be released (cc @Nicogene @pattacini), but if you all agree for me it's ok to disable it until that moment |
Discussed F2F w/ @traversaro; let's wait for the Distro 2025.02 to tag icub-main. |
Ok, since we are waiting for the distro to tag icub-main we have two possibilities:
|
Probably, option 2 is the best. |
Thanks! Good to go for me once the PR is happy. We will address eventual test problems once we enable the tests. |
Thanks! Merging then 🚀 |
This PR adds the
coupled_pendulum
tutorial. Tested:coupled_pendulum.mp4
It's a draft PR since the corresponding unit test is still missing.
cc @xela-95 @traversaro @Nicogene