Bindings: fix "and" to "&&" for preprocessor #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But the generation was not failing, right? |
traversaro
added
PR Status: Changelog - Not Required
|
I guess that the changelog is not required, as this should have been covered by the previous PR. |
|
No, it wasn't failing - I guess it was skipping that part?!? |
|
There is something fishy. |
traversaro
approved these changes
Aug 22, 2018
|
Travis failure is unrelated, see #880 (comment) . |
Nicogene
added
Component: Bindings
|
Isn't possible that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silly mistake of mine in #1830 (been programming Python recently ..).
The following error is resolved:
Sorry for that.