Dead Swerve module fix, the funky shooter feedforward solution made proper, and code cleanup 🐀⚡️🌧🥖🍲🗼🛵🍾👨👦👦⛑🧛♂️🤰✍️🎉🚨📰👨🍳 #179
+283
−388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAKBS2412
reviewed
Jun 6, 2022
This reverts commit a4d96d5.
TAKBS2412
reviewed
Sep 3, 2022
SumedhP
changed the title
SumedhP
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the suggestions implemented by 2930 in the SDS thread: https://www.chiefdelphi.com/t/official-sds-mk3-mk4-code/397109/174
Basically, the absolute encoder repair occurs on the set method calls. By trying to set in periodic it should check if the absolute encoder is set up and then if not, do its reseeding. Shouldn't actually move robot cuz WPI stops motor movement when disabled, may potentially test CAN bus
Currently untested