Add explicit casts to *alloc and djb2 calls #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `void *` return value of realloc and calloc needs to be explicitly cast for C++ compliance. The djb2 function takes `const unsigned char *` as input, but a `char *` is passed, so we need to explicitly cast it for C++ compliance.
robstolarz
requested changes
Aug 16, 2018
| @@ -34,7 +34,7 @@ static unsigned long djb2(const unsigned char *str) { | |||
|
|
|||
| // bool: did it work? | |||
| static bool setcapacity(rsht_ht *ht, const size_t capacity) { | |||
| rsht_entry *items = realloc(ht->items, capacity * sizeof(rsht_entry)); | |||
| rsht_entry *items = (rsht_entry *)realloc(ht->items, capacity * sizeof(rsht_entry)); | |||
There was a problem hiding this comment.
Could you put a space between casts and things they cast?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
void *return value of realloc and calloc needs to be explicitly cast for C++ compliance. The djb2 function takesconst unsigned char *as input, but achar *is passed, so we need to explicitly cast it for C++ compliance.