Snake-case-ify commented-out def names #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanCVanB
changed the title
|
Ooh, I missed some - one moment... |
JanCVanB
force-pushed
the
snake-ify_commented_function_names
branch
from
eee2450 to
feea8cf
Compare
JanCVanB
changed the title
JanCVanB
force-pushed
the
snake-ify_commented_function_names
branch
from
7fcae19 to
7c5639a
Compare
|
Ready for review! |
Anton-4
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Thanks @JanCVanB! Perhaps our language server rename should check for everything between backticks on comments as well... I made roc-lang/roc#7565 for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used my editor's Find feature with the regex
[^a-zA-Z0-9][a-z][a-z0-9]*[A-Z]+[a-z0-9]*across all*.rocfiles.