Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify dir names in example #323

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Clarify dir names in example #323

merged 1 commit into from
Jan 31, 2025

Conversation

JanCVanB
Copy link
Contributor

@JanCVanB JanCVanB commented Jan 30, 2025 •
edited
Loading

empty-dir, nested-dir, and another-dir are much easier to understand than dirExampleE, dirExampleA, and dirExampleD.

CC @lukewilliamboswell @smores56

Anton-4
Anton-4 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed :)

@Anton-4 Anton-4 merged commit b1ed9b8 into roc-lang:main Jan 31, 2025
5 checks passed
@JanCVanB JanCVanB deleted the clarify_example_dir_names branch February 6, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-4 Anton-4 Anton-4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanCVanB @Anton-4