Fix LSP panic on negative position coordinates - #10858
Open
JRI98 wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThe PR prevents malformed LSP position coordinates from reaching unsigned position operations.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/lsp/handlers/document_highlight.zig | Replaces fallback-to-zero parsing with explicit validation and checked coordinate conversion, fully addressing the prior finding. |
| src/lsp/handlers/selection_range.zig | Validates every requested position and safely abandons accumulated results before returning one invalid-parameters response. |
| src/lsp/handlers/completion.zig | Rejects coordinates outside the valid u32 range before document-position processing. |
| src/lsp/handlers/definition.zig | Uses checked coordinate conversion and returns an invalid-parameters response on conversion failure. |
| src/lsp/handlers/hover.zig | Uses checked coordinate conversion to prevent negative or oversized values from reaching lookup logic. |
| src/lsp/test/handler_unit_tests.zig | Adds regression coverage confirming negative coordinates produce invalid-parameters errors without panicking. |
Reviews (2): Last reviewed commit: "Fix LSP panic on negative position coord..." | Re-trigger Greptile
JRI98
enabled auto-merge
August 19, 2026 00:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LSP request handlers panicked when receiving negative line or character numbers in request position parameters due to unvalidated integer conversion to unsigned types.
This was addressed by validating incoming position line and character integers across LSP request handlers, returning an invalid parameters error or handling out-of-range values gracefully rather than crashing.
Fixes #10854