Fixed issue #2457 #7361
Fixed issue #2457 #7361
Conversation
Commas before function arguement types on lines will no longer give errors.
…to whitespace_func
| @@ -605,7 +605,10 @@ fn expression<'a>( | |||
| .parse(arena, state, min_indent)?; | |||
|
|
|||
| let (p2, rest, rest_state) = zero_or_more(skip_first( | |||
| backtrackable(byte(b',', EType::TFunctionArgument)), | |||
| backtrackable(skip_first( | |||
There was a problem hiding this comment.
Rather than doing skip_first, I think we need to be preserving this space in the tree. Otherwise we could accidentally lose a comment when formatting, for example.
Rather than separately tracking spaces before/after the comma, we should probably just merge them. There's a handy merge_spaces function for just that purpose.
|
Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked |
Fixed the issue of not allowing white space before commas that separated function arguments