Cleanup of the file kernel/nativecode.ml#22108
Open
IBBXEF wants to merge 2 commits into
Open
Conversation
coqbot-app
Bot
added
the
needs: full CI
Member
|
@coqbot run full ci |
coqbot-app
Bot
removed
the
needs: full CI
ppedrot
approved these changes
Jun 9, 2026
yannl35133
reviewed
Jun 9, 2026
| let sig_str = if arity > 0 then aux "of Nativevalues.t" (arity-1) else "" in | ||
| let cstr = string_of_construct "" ~constant:true ind tag in | ||
| Format.fprintf fmt " | %s %s@\n" cstr sig_str | ||
| Format.fprintf fmt " | %s @\n" cstr |
Contributor
There was a problem hiding this comment.
Suggested change
| Format.fprintf fmt " | %s @\n" cstr | |
| Format.fprintf fmt " | %s@\n" cstr |
also unneeded
ppedrot
added
the
needs: progress
coqbot-app
Bot
added
the
needs: full CI
…own) and made simplifications allowed by this removal.
Member
|
@coqbot run full ci |
coqbot-app
Bot
removed
the
needs: full CI
ppedrot
removed
the
needs: progress
ppedrot
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While tinkering with the native code generation, I found two problems in the file nativecode.ml.
While those do not change the behaviour of the code in any way, they can be confusing to the reader and may cause uneeded computation.