Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for optional headers #29

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

punnie
Copy link
Contributor

@punnie punnie commented Aug 20, 2023

This PR adds the flag PrintHeaders to the table struct that specifies whether headers should be printed or not.

This may be useful when output is being piped to other processes, where having a header is less desirable, and saves from doing a call to head (or tail) before processing.

Thank you for this wonderful library. Please let me know what you think about this, and if any more changes are necessary.

@IdlePhysicist
Copy link

@rodaine would it be possible to get this PR caught up and merged? I am happy to take it on if @punnie is unable. This functionality would be beneficial in a project of mine.

@punnie punnie force-pushed the allow-for-optional-headers branch from 13ac60a to a897d7d Compare August 2, 2024 13:32
@punnie
Copy link
Contributor Author

punnie commented Aug 2, 2024

Hey y'all!

Hadn't realised there was a call to action here, sorry for the delay.

Resolved the conflict by interacting with a new feature added in PR #40 in a way that made sense to me: do not print the header separator if headers are not to be printed. Please let me know if this is the intended behaviour or if there are other changes I need to do.

Thanks!

@rodaine
Copy link
Owner

rodaine commented Aug 2, 2024

Thanks for the patch (and everyone's patience on getting this merged)!

@rodaine rodaine merged commit 6d722ac into rodaine:master Aug 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants