Compact fix for color generation in theme.json #3222
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing I found that the
themeContent
CSS sometimes does not contain a closing curly bracket, meaning the index of the last bracket was -1. This cut off the final--color-example: #abcdef
definition by one character, leading to the generated theme.json color for that one to be:By checking for the presence of the final bracket, we can either slice to there, or to the end of the content if it is not present.