Fix author response responder#103
Conversation
| - author1 | ||
| - author-others | ||
| remove_labels: | ||
| - 4/review(s)-in-awaiting-changes |
There was a problem hiding this comment.
This can't go here, i don't thinik? Because this responder is triggered each time a review is submitted, including the first time. In those cases, the label needs to remain at 3/
There was a problem hiding this comment.
no, this is for the author submit response responder
There was a problem hiding this comment.
But my comment still applies. Plus note line 16:
buffy/config/settings-production.yml
Line 16 in 044d630
So that badge is added by this responder, but only once all reviews are in. This responder should not remove it.
| - reviewers-list | ||
| remove_labels: | ||
| - 5/awaiting-reviewer(s)-response | ||
| - 4/review(s)-in-awaiting-changes |
There was a problem hiding this comment.
But this looks to me like it should work:
mpadge
left a comment
mpadge
left a comment
There was a problem hiding this comment.
I think you need to remove the added lines 22-23?
|
@maelle The bigger problem here seems to be that we have no automated transition from 4/ to 5/. We should address that issue! |
|
@mpadge I'm lost. The automatic transition is the author's submitting their response (well, it should be). https://devdevguide.netlify.app/bot_cheatsheet#finalize-repo-transfer Can you suggest changes? |
2 participants
No description provided.