Skip to content

expand all 'only: editors' to stats-editors as well#112

Closed
mpadge wants to merge 1 commit into
ropenscifrom
ropensci-stats-editors
Closed

expand all 'only: editors' to stats-editors as well#112
mpadge wants to merge 1 commit into
ropenscifrom
ropensci-stats-editors

Conversation

@mpadge

@mpadge mpadge commented Jun 4, 2025

Copy link
Copy Markdown
Collaborator

@xuanxu Can you please give feedback here on the one potential issue that the stats-editors team this adds to the config is a sub-team of editors. I think original idea was to have stats-editors as a strict subset, but we currently have entries in stats-editors who are not in editors. Might be best for us to ensure strict subset on our org side, rather than merge this PR? @maelle what are your thoughts?

@xuanxu

xuanxu commented Jun 4, 2025

Copy link
Copy Markdown
Collaborator

This change will grant access to all people in editors and to all people in stat-editors. Ideally is better to have a team with all the people (and just the people) you want to be able to use those commands, but if you trust everyone in both these teams I think there's no problem.

@mpadge

mpadge commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator Author

We no longer need this, as we updated the team structures instead, so I'm going to close

@mpadge mpadge closed this Jul 3, 2025
xuanxu pushed a commit that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants