Skip to content

make transfer less of a requirement #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 5, 2025
Merged

make transfer less of a requirement #864

merged 8 commits into from
May 5, 2025

Conversation

maelle
Copy link
Member

@maelle maelle commented Feb 3, 2025

No description provided.

@maelle
Copy link
Member Author

maelle commented Mar 11, 2025

@mpadge this is the blocked PR

@mpadge
Copy link
Member

mpadge commented Mar 11, 2025

@mpadge this is the blocked PR

Do you mean you want me to review and approve it?

@maelle
Copy link
Member Author

maelle commented Mar 11, 2025

No, that's the one that first needs discussion of COC implications at a staff meeting.

@maelle maelle marked this pull request as ready for review March 13, 2025 14:37
@maelle
Copy link
Member Author

maelle commented Mar 13, 2025

@mpadge once reviewed I'll work on translations

@maelle
Copy link
Member Author

maelle commented Mar 13, 2025

@mpadge to be reviewed together with https://github.com/ropensci/software-review/pull/682/files

@maelle maelle requested a review from mpadge March 27, 2025 14:43
mpadge
mpadge approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just rewrote that heading because all others in that chapter are short, succinct, and heading-like, where in former form that was really a sentence that belonged in text. Hope that's okay! Otherwise minor tweaks and all is grand 🚢

This was referenced Mar 28, 2025
Merged
Closed
Merged
maelle
maelle commented Mar 28, 2025
View reviewed changes
Copy link
Member Author

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beatrizmilz could you please review the changes made here... and in other PRs? I've added links, these are the PRs for pkg_ci.pt.Rmd, softwarereview_editor.pt.Rmd and softwarereview_intro.pt.Rmd

@maelle maelle requested review from a team and beatrizmilz and removed request for a team April 24, 2025 10:40
@beatrizmilz
Copy link
Contributor

Hi @maelle! Sorry for taking so long. I reviewed all the files with .pt in this PR!

@maelle maelle requested review from a team as code owners May 5, 2025 07:45
@maelle maelle requested review from yabellini and fblpalmeira and removed request for a team May 5, 2025 07:45
@maelle
Copy link
Member Author

maelle commented May 5, 2025

Thank you @beatrizmilz!!

@yabellini could you please review the changes in the Spanish versions? Thank you!

yabellini
yabellini reviewed May 5, 2025
View reviewed changes
@yabellini
Copy link
Member

@maelle it is done. I leave a few comments. :-)

@maelle @yabellini
Apply suggestions from code review
357832d 
Co-authored-by: Yanina Bellini Saibene <[email protected]>
@maelle maelle merged commit 86da26f into main May 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yabellini yabellini yabellini left review comments

@beatrizmilz beatrizmilz beatrizmilz left review comments

@mpadge mpadge mpadge approved these changes

@fblpalmeira fblpalmeira Awaiting requested review from fblpalmeira fblpalmeira is a code owner automatically assigned from ropensci/pt-translators

Assignees
No one assigned
Labels
content 📃 needs-translation-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maelle @mpadge @beatrizmilz @yabellini