Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default nix config to ship with pkg #16

Merged

Conversation

philipp-baumann
Copy link
Collaborator

addresses #14

@philipp-baumann
Copy link
Collaborator Author

@b-rodrigues guess on Win there is a build failure because of time consumed in the CI/CD pipeline.

@philipp-baumann
Copy link
Collaborator Author

Guess it makes sense to include RStudio as IDE in default config?

@philipp-baumann
Copy link
Collaborator Author

Also, we currently have a fixed commit tag for {rix}. Maybe in future it would make sense to refer to latest stable pkg commit, if you decide to publish it there :-)

@b-rodrigues b-rodrigues merged commit 2c835db into ropensci:master Aug 3, 2023
@b-rodrigues
Copy link
Contributor

I made some changes to your pull request before merging:

  • the environment in inst/extdata/default.nix does not install RStudio anymore. This is because this will be used for a temporary Nix shell simply to create a first, complete environment
  • changed some stuff to the readme

Let me know what you think about the readme :)

@philipp-baumann
Copy link
Collaborator Author

like it!

@philipp-baumann
Copy link
Collaborator Author

Will get back to tmrw about readme. Need to catch some sleep 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants