Add new members for PID controller parameters #1585
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
destogl,
LukasMacha97,
mamueluth,
mcbed,
progtologist and
saikishor
|
I set this as draft until we approved the control_toolbox PR. |
ViktorCVS
force-pushed
the
master
branch
2 times, most recently
from
403300b to
ed6de3d
Compare
Adds new members to PID controller parameters to support saturation and three new anti-windup features.
Replace the `subset_of` validator with `one_of` because `antiwindup_strategy` is a single string, not a string_array.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1585 +/- ##
=======================================
Coverage 85.69% 85.70%
=======================================
Files 123 123
Lines 11897 11896 -1
Branches 1015 1014 -1
=======================================
Hits 10195 10195
Misses 1379 1379
+ Partials 323 322 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new members to the PID controller parameters to support saturation and three new anti-windup features.
These changes support modifications made to the PID controller in the control_toolbox package. For more details, see ros-controls/control_toolbox#298.
If this PR is approved, it should be merged together with the main PR in the control_toolbox package referenced above.