Add rustup dependency to rosdep base.yaml #44640
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for sending a pull request to ROS distro!
This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.
ROS Distro Considerations
- ROS Distributions are created using REP-134 Standards Track as a guide.
- Your package name should comply to REP-144 ROS Package Naming
- Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
- Your package must contain an OSI approved license. Your
package.xmlfile must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details. - A publicly available, open source, repository for your ROS package.
- While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
- If you would like, you may join our Discord Server and ask questions in the
#infra-helpchannel.
Package Considerations
Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.
- REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
- Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
- Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
- We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.
Need Help?
Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ Platforms for new rosdep rules are valid
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
There was a problem hiding this comment.
The rule itself here is ok, but we may need to have some extra rules about compatibility with debian packaging, like we do with pip such that people know it's incompatible with being able to make a release.
The proposed changes moving the zenoh compiler forward connected to this are a major issue that needs to be discussed.
|
Now seeing the build test results it looks like the proposed rules don't exist on several platforms either. |
Please add the following dependency to the rosdep database.
Package name:
rustup
Package Upstream Source:
https://github.com/rust-lang/rustup
Purpose of using this:
rmw_zenoh internal core is written in Rust and it uses the
cargoas dependency for the build. While this is currently working, installing directlycargois pinning the Rust toolchain to a quite old version in many distributions. For example, on Ubuntu24.04the shipped Rust toolchain is1.75.Since Jazzy the Zenoh project has globally pinned the Rust version to 1.75.
However, this is now a limitation for the project since newer Rust toolchains have been release and downstream dependencies already started requiring more recent Rust versions (e.g. eclipse-zenoh/zenoh#1800).
rustup is a tool that installs Rust on the system from the official release channels, enabling to easily switch between toolchain versions and keep them updated.
By depending on
rustupinstead ofcargormw_zenoh (and any other Rust project) will be able to use the required Rust toolchain and not forced to use the toolchain shipped with any distro.Distro packaging links:
Links to Distribution Packages