Make system default durability volatile #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadunund
force-pushed
the
yadu/make_default_durability_volatile
branch
from
e1124f3 to
ce92cb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the system default durability to volatile from transient_local. This change is the better align with QoS settings in other RMWs #485. While rmw_zenoh does not necessarily have to conform to other RMW settings but the durability, and particularly setting to transient_local by default, might lead to unintended behavior in tests and applications that users might have developed. So it makes sense to switch to volatile by default.
I've ran the usual CI tests and didn't see any new regressions. (rclpy/test_logging is flaky).
cc: @JEnoch @YuanYuYuan