zenoh_cpp_vendor: Do not call externalproject_add_stepdependencies if projects are not vendored #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… projects are not vendored Signed-off-by: Silvio Traversaro <[email protected]>
Signed-off-by: Silvio Traversaro <[email protected]>
This was referenced Jul 3, 2025
|
Hi @traversaro, thanks for the PR. Looking forward to the upstream addition landing. |
|
@traversaro any update on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is draft PR that just showcases how ament/ament_cmake#592 works, please do not merge until that PR has been merged as released (even if given how variables are assigned, the PR is effectively a no operation even if ament/ament_cmake#592 is not merged.
Is this user-facing behavior change?
No, the default behavior is exactly the same.
Did you use Generative AI?
No.
Additional Information
See ament/ament_cmake#592 for more context.