Bump Zenoh to v1.5.0#728
Merged
Merged
Conversation
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Contributor
|
An issue on Windows is currently blocking this PR. CUSTOMBUILD : error : failed to run custom build command for `zenoh-c v1.5.0 (C:\dev\build\zenoh_cpp_vendor\zenoh_c_vendor-prefix\src\zenoh_c_vendor-build\debug)` [C:\dev\bu
ild\zenoh_cpp_vendor\zenoh_c_vendor-prefix\src\zenoh_c_vendor-build\cargo.vcxproj] [C:\dev\build\zenoh_cpp_vendor\zenoh_c_vendor.vcxproj]
Caused by:
process didn't exit successfully: `C:\dev\build\zenoh_cpp_vendor\zenoh_c_vendor-prefix\src\zenoh_c_vendor-build\debug\target\debug\build\zenoh-c-6f1299e9a31ea4df\build
-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at C:\dev\build\zenoh_cpp_vendor\zenoh_c_vendor-prefix\src\zenoh_c_vendor\buildrs\cbindgen_generator.rs:750:28:
no sigatures found for building generic z_take_from_loaned
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'C:\dev\build\ze
noh_cpp_vendor\zenoh_c_vendor-prefix\src\zenoh_c_vendor-build\CMakeFiles\6f1ba7ff810a5943bfc66c2391b37f0a\b3ff8e47e00e032d.rule;C:\dev\build\zenoh_cpp_vendor\zenoh_c_vendor-
prefix\src\zenoh_c_vendor-build\CMakeFiles\6f1ba7ff810a5943bfc66c2391b37f0a\cargo.rule;C:\dev\build\zenoh_cpp_vendor\zenoh_c_vendor-prefix\src\zenoh_c_vendor\CMakeLists.txt'
exited with code 101. [C:\dev\build\zenoh_cpp_vendor\zenoh_c_vendor-prefix\src\zenoh_c_vendor-build\cargo.vcxproj] [C:\dev\build\zenoh_cpp_vendor\zenoh_c_vendor.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'C:\dev\build\ze
noh_cpp_vendor\CMakeFiles\fd1819b1f58a0e8a0c7cbc7608cc22bb\zenoh_c_vendor-mkdir.rule;C:\dev\build\zenoh_cpp_vendor\CMakeFiles\fd1819b1f58a0e8a0c7cbc7608cc22bb\zenoh_c_vendor
-download.rule;C:\dev\build\zenoh_cpp_vendor\CMakeFiles\fd1819b1f58a0e8a0c7cbc7608cc22bb\zenoh_c_vendor-update_disconnected.rule;C:\dev\build\zenoh_cpp_vendor\CMakeFiles\fd1
819b1f58a0e8a0c7cbc7608cc22bb\zenoh_c_vendor-patch_disconnected.rule;C:\dev\build\zenoh_cpp_vendor\CMakeFiles\fd1819b1f58a0e8a0c7cbc7608cc22bb\zenoh_c_vendor-configure.rule;
C:\dev\build\zenoh_cpp_vendor\CMakeFiles\fd1819b1f58a0e8a0c7cbc7608cc22bb\zenoh_c_vendor-build.rule;C:\dev\build\zenoh_cpp_vendor\CMakeFiles\fd1819b1f58a0e8a0c7cbc7608cc22bb
\zenoh_c_vendor-install.rule;C:\dev\build\zenoh_cpp_vendor\CMakeFiles\364c97fed69e850a25245c13389e3fc9\zenoh_c_vendor-complete.rule;C:\dev\build\zenoh_cpp_vendor\CMakeFiles\
d3678a235e47ef28fd46ead2d10335d9\zenoh_c_vendor.rule;C:\dev\rolling\src\ros2\rmw_zenoh\zenoh_cpp_vendor\CMakeLists.txt' exited with code 1. [C:\dev\build\zenoh_cpp_vendor\ze
noh_c_vendor.vcxproj]
---
Failed <<< zenoh_cpp_vendor [7min 3s, exited with code 1] |
Contributor
|
Https://github.com/eclipse-zenoh/zenoh-c/pull/1079 will address the windows compilation issue. |
Contributor
|
Pulls: #728
|
JEnoch
approved these changes
Aug 12, 2025
Contributor
|
The failing tests on CI are not related to Zenoh 1.5.0:
|
Contributor
|
https://github.com/Mergifyio backport kilted jazzy humble |
mergify Bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
Signed-off-by: ChenYing Kuo <evshary@gmail.com> Co-authored-by: yuanyuyuan <az6980522@gmail.com> Co-authored-by: Julien Enoch <julien.e@zettascale.tech> (cherry picked from commit 2477f71)
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
Signed-off-by: ChenYing Kuo <evshary@gmail.com> Co-authored-by: yuanyuyuan <az6980522@gmail.com> Co-authored-by: Julien Enoch <julien.e@zettascale.tech> (cherry picked from commit 2477f71)
mergify Bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
Signed-off-by: ChenYing Kuo <evshary@gmail.com> Co-authored-by: yuanyuyuan <az6980522@gmail.com> Co-authored-by: Julien Enoch <julien.e@zettascale.tech> (cherry picked from commit 2477f71)
This was referenced Aug 12, 2025
JEnoch
added a commit
that referenced
this pull request
Aug 12, 2025
JEnoch
added a commit
that referenced
this pull request
Aug 12, 2025
JEnoch
added a commit
that referenced
this pull request
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump Zenoh to 1.5.0, making the following changes of commit ids:
It includes those notable changes:
KeyExpr::try_from<&str>and add some tests eclipse-zenoh/zenoh#2025Is this user-facing behavior change?
None
Did you use Generative AI?
None
Additional Information
None