Skip to content

Added zenoh security documention #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 22, 2025
Merged

Added zenoh security documention #4977

merged 7 commits into from
May 22, 2025

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jan 29, 2025

As part of the effort ros2/rmw_zenoh#438 to include security in Zenoh, I started this PR that includes some documentation about how to enable and use zenoh with security

@ahcorde
Added zenoh security documention
608738d 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde mentioned this pull request Jan 29, 2025
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/15197746943/artifacts/3181027417.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4977/index.html in your favorite browser

@Yadunund
Copy link
Member

Yadunund commented Apr 7, 2025

@ahcorde should we update this PR to refer to this README or do we want to move the contents of the README here?

fujitatomoya
fujitatomoya reviewed Apr 7, 2025
View reviewed changes
ahcorde added 2 commits April 15, 2025 12:52
@ahcorde
Feedback and note about secutiry on Zenoh
c868e92 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
make lintes happy
2082775 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde marked this pull request as ready for review April 15, 2025 10:59
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 15, 2025

@ahcorde should we update this PR to refer to this README or do we want to move the contents of the README here?

@Yadunund Finally I decided to add a note an refer to the Github repository, It will be easy to update and maintain the instructions there.

@ahcorde ahcorde requested a review from fujitatomoya April 15, 2025 11:00
fujitatomoya
fujitatomoya reviewed Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde almost lgtm, a couple of minor comments.

@ahcorde
feedback
d71bc62 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde requested a review from fujitatomoya April 21, 2025 09:05
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 24, 2025

friendly ping @Yadunund @fujitatomoya

Yadunund
Yadunund requested changes Apr 24, 2025
View reviewed changes
@ahcorde
review feedback
a34cffc 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde requested a review from Yadunund May 8, 2025 13:15
fujitatomoya
fujitatomoya reviewed May 8, 2025
View reviewed changes
@ahcorde @fujitatomoya
Update source/Tutorials/Advanced/Security/Introducing-ros2-security.rst
2ba1195 
Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
fujitatomoya
fujitatomoya approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yadunund i will leave this to you, can you merge if you think this is ready?

@ahcorde
Copy link
Contributor Author

ahcorde commented May 21, 2025

friendly ping @Yadunund

Yadunund
Yadunund approved these changes May 22, 2025
View reviewed changes
@ahcorde @Yadunund
Update source/Tutorials/Advanced/Security/Introducing-ros2-security.rst
21f2392 
Co-authored-by: yadunund <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde added the backport-kilted backport to kilted at reviewers discretion; from rolling to kilted label May 22, 2025
@ahcorde ahcorde merged commit 78c54d4 into rolling May 22, 2025
5 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/security_zenoh branch May 22, 2025 22:20
mergify bot pushed a commit that referenced this pull request May 22, 2025
@ahcorde @fujitatomoya
@Yadunund @mergify
Added zenoh security documention (#4977)
3b0190f 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: yadunund <[email protected]>
(cherry picked from commit 78c54d4)
@mergify mergify bot mentioned this pull request May 22, 2025
Merged
ahcorde added a commit that referenced this pull request May 22, 2025
@mergify @ahcorde
@fujitatomoya @Yadunund
Added zenoh security documention (#4977) (#5660)
5bdd55d 
(cherry picked from commit 78c54d4)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: yadunund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@Yadunund Yadunund

Labels
backport-kilted backport to kilted at reviewers discretion; from rolling to kilted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @Yadunund @fujitatomoya