Limit search pattern for remove command #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
force-pushed
the
libsolv-error
branch
2 times, most recently
from
6d49ac8 to
55b0c1a
Compare
ppisar
reviewed
Jan 4, 2024
|
Could you make a commit subject more specific? Like "Limit search pattern for remove command to NEVRAs and files" |
|
This is a quite serious change which deserves a test. Do you plan enhancing ci-dnf-stack? |
It prevents additional removal after succesful remove using the same spec. Spec `foo`. The original code during the first run removes (dnf5 remove foo) all packages with the name `foo`. In the next run (dnf5 remove foo) it removes all packages providing `foo`. The next run will remove packages providing binary `foo`. This behavior is inconsistent. Resolves: https://issues.redhat.com/browse/RHEL-5747
j-mracek
force-pushed
the
libsolv-error
branch
from
a58f0ac to
75ba583
Compare
The code require following change of CI - rpm-software-management/ci-dnf-stack#1430. It removes all tests for formal behavior and add one test for the new behavior. |
j-mracek
added a commit
to j-mracek/ci-dnf-stack
that referenced
this pull request
Jan 5, 2024
The new behavior is more stable for cases when the same spec is used multiple times with remove command. Requires: rpm-software-management/dnf5#1126
|
@ppisar Done |
ppisar
reviewed
Jan 5, 2024
ppisar
reviewed
Jan 5, 2024
It unify style with remove command, because it uses the same argument type.
j-mracek
force-pushed
the
libsolv-error
branch
from
75ba583 to
b26fe41
Compare
|
@ppisar Thank you for couching it. Fixed. |
Merged
via the queue into
rpm-software-management:main
with commit Jan 8, 2024
870a8a0
5 of 9 checks passed
j-mracek
added a commit
to j-mracek/ci-dnf-stack
that referenced
this pull request
Jan 8, 2024
The new behavior is more stable for cases when the same spec is used multiple times with remove command. Requires: rpm-software-management/dnf5#1126
ppisar
pushed a commit
to rpm-software-management/ci-dnf-stack
that referenced
this pull request
Jan 8, 2024
The new behavior is more stable for cases when the same spec is used multiple times with remove command. Requires: rpm-software-management/dnf5#1126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It prevents additional removal after succesful remove using the same spec. Spec
foo. The original code during the first run removes (dnf5 remove foo) all packages with the namefoo. In the next run (dnf5 remove foo) it removes all packages providingfoo. The next run will remove packages providing binaryfoo. This behavior is inconsistent.Resolves: https://issues.redhat.com/browse/RHEL-5747
CI-tests - rpm-software-management/ci-dnf-stack#1430