Load SystemState only when required #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
force-pushed
the
system-state-optimize-report
branch
from
336ea34 to
7e98d83
Compare
kontura
force-pushed
the
system-state-optimize-report
branch
from
7e98d83 to
4acf5a6
Compare
Commands that don't need system state are more efficient because they don't have to load it. They also don't run into problems caused by the dnf4 history conversion.
Otherwise the database is created and there is a rather complex sql error because we expect the database to have to specific tables in the following queries.
The system state is now loaded (converted) only when required. There are two options: 1. We want to modify system state which requires privileges anyway. 2. We want to only read system state. This could require privileges only if we need to convert the system state from dnf4 db. If we fail to save the converted system state the error is hidden in `reset_packages_states` and we use it normally just from memory. This means the conversion will repeat until successfully saved.
kontura
force-pushed
the
system-state-optimize-report
branch
from
4acf5a6 to
e898cc5
Compare
kontura
changed the title
|
OK |
Merged
via the queue into
rpm-software-management:main
with commit Feb 10, 2025
7558a72
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.