load_plugins: Preserve original exception with failure information #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation threw an exception with a list of plugins that failed to load. We usually got the name of one configuration file. Information about the reason for the failure was not included in the exception. Now the code throws an exception for the first failed plugin. Exception contains the full path (not just the filename) and includes the original exception from the source of the error.
|
I like it, thank you! |
Merged
via the queue into
rpm-software-management:main
with commit Feb 13, 2025
2dfb6e0
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1336
The original implementation threw an exception with a list of plugins that failed to load. We usually got the name of one configuration file. Information about the reason for the failure was not included in the exception.
Now the code throws an exception for the first failed plugin. Exception contains the full path (not just the filename) and includes the original exception from the source of the error.