Create a pipe and open files with the close-on-exec flag #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrohel
force-pushed
the
open_descriptors_close_on_exec
branch
from
400ccc1 to
633f1b6
Compare
|
/packit test |
An application that uses libdnf can create a child process (`fork`) in another thread and execute the program in it. This will leak open descriptors to the newly executed program. The close-on-exec flag (`O_CLOEXEC`) ensures that the descriptors are closed and not passed to the newly running program (they are closed).
jrohel
force-pushed
the
open_descriptors_close_on_exec
branch
from
633f1b6 to
658d5ab
Compare
Merged
via the queue into
rpm-software-management:main
with commit Feb 20, 2025
07db01d
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An application that uses libdnf can create a child process (
fork) in another thread and execute the program in it. This will leak open descriptors to the newly executed program.The close-on-exec flag (
O_CLOEXEC) ensures that the descriptors are not passed to the newly running program (they are closed in the child process).