Fix total number of transaction progress bars #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the transaction, the total number of steps needed and thus the progress bars needed is calculated. The original calculation assumed that if new packages enter the system through transactions, the first step would be to verify them. However, package verification can be disabled. This modification will add the verification step to the total number of steps only if verification is performed.
ppisar
approved these changes
Feb 24, 2025
Merged
via the queue into
rpm-software-management:main
with commit Feb 24, 2025
a9ddd67
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the transaction, the total number of steps needed and thus the progress bars needed is calculated. The original calculation assumed that if new packages enter the system through transactions, the first step would be to verify them. However, package verification can be disabled.
This modification will add the verification step to the total number of steps only if verification is performed.
Closes: #2079