Fix: let copr plugin to respect the installroot option #2081
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates repofiles in
installroot
to respect its location. Howeverdnf4 copr
behaves the same way asdnf5 copr
with--use-host-config
:the repofile is created inside
/etc/yum.repos.d
, the installroot is ignored.But
dnf4 install buildtag --installroot=/tmp/dnf4
somehow uses the repofile in/etc/yum.repos.d
. The same steps with dnf5 will result inbecause dnf5 by default looks to the installroot. I don't know whether we want to change the default behaviour of
dnf copr
between versions 4 and 5, but I'd expect thednf5 copr
command to create repofile insideinstallroot
, so this PR should address this issue.Fix #1497