Add comps upgrade to system upgrade, comps improvements #2086
+103
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to check for this otherwise the empty string cannot be converted to valid group package type.
kontura
force-pushed
the
system-upgrade-comps
branch
from
b134329 to
835841a
Compare
This would be problematic when we merge group/environment definitions from all availables repos. When a repo with some part of a group definition would be unavailable or disabled an upgrade would clear contained packages. This matches dnf4 behavior.
kontura
force-pushed
the
system-upgrade-comps
branch
from
835841a to
472aadb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1817
Test update: rpm-software-management/ci-dnf-stack#1641