offline transactions: Keep user informed about scriptlet execution #2087
+41
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use explicit std::vector<std::string> constructor instead of uniform initialization to allow range based construction.
Use prepared connection to the System Bus. Otherwise the default connection to Session Bus would be created.
It's '--ping', not 'ping'.
The `amount` parameter counts transaction items starting from 0, but for humans, it's more natural to start from 1.
m-blaha
force-pushed
the
mblaha/system-upgrade-scriptlets
branch
from
c8f7a9f to
edf90a0
Compare
Scriptlet execution can take a significant amount of time. Inform the user when it starts.
m-blaha
force-pushed
the
mblaha/system-upgrade-scriptlets
branch
from
edf90a0 to
c5fe158
Compare
m-blaha
force-pushed
the
mblaha/system-upgrade-scriptlets
branch
from
c5fe158 to
1be9a72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scriptlet execution can take a significant amount of time. Inform the user when
it starts.
Resolves: #1667