Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean tests file #1179

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Clean tests file #1179

merged 4 commits into from
Feb 1, 2024

Conversation

i12momal
Copy link
Contributor

@i12momal i12momal commented Jan 30, 2024 •
edited by danigm
Loading

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 31, 2024
View reviewed changes
danigm
danigm requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@danigm danigm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ENGLISH_ENVIROMENT is not replaced everywhere, there are some places where it's still there with the typo. I can find the old variable name in the following files:

  • rpmlint/lddparser.py
  • rpmlint/checks/SpecCheck.py
  • rpmlint/checks/AppDataCheck.py
  • rpmlint/checks/MenuXDGCheck.py
  • rpmlint/checks/PostCheck.py
  • rpmlint/checks/MenuCheck.py
  • rpmlint/checks/BashismsCheck.py

danigm
danigm requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@danigm danigm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, it's a good starting point to have common fake packages for tests. But the files are not following the coding styling.

You can run the flake8 command line tool to see the errors and suggestions. Try to fix all the errors reported.

danigm
danigm approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@danigm danigm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@danigm danigm merged commit 3192919 into rpm-software-management:main Feb 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danigm danigm danigm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i12momal @danigm