Analyzers

[ErikEJ]

fixes #170

Includes support for the built-in rules and the list of rules here: https://github.com/tcartwright/SqlServer.Rules/blob/master/docs/table_of_contents.md
and here: https://github.com/davebally/TSQL-Smells

Includes ability to supress rules and groups of rules

[jmezach]

LGTM. I was just wondering if we need to add a test project for this as well.

[ErikEJ]

@jmezach I will add a test project, just need to .Targets in place, maybe you can help?

[ErikEJ]

@jmezach I tried and failed, as you can see from a previous commit, maybe you can guide me? cd58dfb

[jmezach]

What problem are you running into?

[ErikEJ]

@jmezach Maybe you can check my commit, this is the build error: https://github.com/rr-wfm/MSBuild.Sdk.SqlProj/actions/runs/8045635831/job/21971290181

[jmezach]

You'll probably want to add a condition on <CodeAnalysisRulesArgument> so that it is only set if certain rules are ignored. Right now you're always passing the -ar command line option, but without any arguments.

[ErikEJ]

@jmezach > You'll probably want to add a condition on

😄 - yeah, makes sense, but I have no clue how to do that - sorry!

[jmezach]

Something like <CodeAnalysisRulesArgument Condition="'$(CodeAnalysisRules)'!=''">-ar $(CodeAnalysisRules)</CodeAnalysisRulesArgument>

[ErikEJ]

@jmezach I got a test project running now

Will do a docs update once this is in

[ErikEJ]

[jmezach]

LGTM :)

[jeffrosenberg]

LGTM, with one small comment