Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspire waitfor + fuller POC #605

Closed
wants to merge 7 commits into from
Closed

Aspire waitfor + fuller POC #605

wants to merge 7 commits into from

Conversation

ErikEJ
Copy link
Collaborator

@ErikEJ ErikEJ commented Aug 8, 2024

No description provided.

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Aug 8, 2024

@jmezach Updated!

@jmezach
Copy link
Member

jmezach commented Aug 13, 2024

This looks like a lot of code that we will need to maintain that isn't necessarily related to this project. It looks like this is going to be something that is going to be built-in to .NET Aspire (see dotnet/aspire#5275), so maybe we should just wait for that and tie it in with that stuff?

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Aug 13, 2024 •
edited
Loading

@jmezach So you are suggesting merging what is in your PR and then await some general Aspire improvements (that seem to be needed in many circumstances) ?

@ErikEJ ErikEJ closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmezach jmezach jmezach left review comments

@jeffrosenberg jeffrosenberg jeffrosenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ErikEJ @jmezach @jeffrosenberg @pksorensen